Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM64/F3D] Fix and update Ui Image Exporter #452

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

Lilaa3
Copy link
Collaborator

@Lilaa3 Lilaa3 commented Sep 10, 2024

Fixes #451

  • Updated: Tex prop is now drawn using ui_image, ui_image has been updated to optionally hide low and high props (are handled by size cmd, does not exist for texture rectangles)
  • materialless_setup func for TexInfo, equivelant to moreSetupFromModel for bpy material-less contexts, obviously cannot handle flipbooks
  • setup_single_tex func for TexInfo, sets up a single texture without the context of the multi texture manager
  • ignore_tex_set bool for fromProp
  • Use only fromProp and updated writeAll
  • Use saveModeSetting (and world defaults) instead of manullay appending each DP command (except for blend color)
  • Removed syncs except for the sync after the texrect cmd to do the reverts
  • Removed deprecated arg for png exporting in save_textures (assumed from fimage)
  • Removed the ) part of the delimiter checked when exporting "Menu", refresh 13 made it (void) instead of ()
  • Some basic ui reordering to match other panels
  • Added 1 cycle variant for non rgba16 exports
  • Fix dynamic displaylists adding an extra comma (caused a compiler error)
  • Fix overwritedata not handeling the aligner and made it so palletes are handeled correctly as well

Fixes Fast-64#451
Missing: Load and set commands and pallets (currently relying on multitex manager, will have to be changed somehow)
Updated: Tex prop is now drawn using ui_image, ui_image has been updated to optionally hide low and high props (are handled by size cmd, does not exist for texrect)
materialless_setup func for TexInfo, equivelant to moreSetupFromModel for bpy material-less contexts, obviously cannot handle flipbooks
ignore_tex_set bool for fromProp
Use only fromProp and updated writeAll
Some basic ui reordering to match other panels
@Lilaa3 Lilaa3 added bug Something isn't working enhancement New feature or request sm64 Has to do with the Super Mario 64 side f3d Has to do with the "f3d" code common to all games labels Sep 10, 2024
@Lilaa3 Lilaa3 marked this pull request as ready for review September 10, 2024 11:44
@Lilaa3 Lilaa3 added the review code please Ask that some other Fast64 dev reviews the code label Sep 10, 2024
Copy link
Contributor

@sauraen sauraen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non SM64 stuff looks okay. Please make sure to test export with some advanced cases like materials with two CI textures before merging.

fast64_internal/f3d/f3d_texture_writer.py Outdated Show resolved Hide resolved
fast64_internal/f3d/f3d_texture_writer.py Outdated Show resolved Hide resolved
Updated: Tex prop is now drawn using ui_image, ui_image has been updated to optionally hide low and high props (are handled by size cmd, does not exist for texture rectangles)
materialless_setup func for TexInfo, equivelant to moreSetupFromModel for bpy material-less contexts, obviously cannot handle flipbooks
setup_single_tex func for TexInfo, sets up a single texture without the context of the multi texture manager
ignore_tex_set bool for fromProp
Use only fromProp and updated writeAll
Use saveModeSetting (and world defaults) instead of manullay appending each DP command (except for blend color)
Removed syncs except for the sync after the texrect cmd to do the reverts
Removed deprecated arg for png exporting in save_textures (assumed from fimage)
Removed the ) part of the delimiter checked when exporting "Menu", refresh 13 made it (void) instead of ()
Some basic ui reordering to match other panels
Added 1 cycle variant for non rgba16 exports
Fix dynamic dls
could not deal with aligner and palletes, now can!
@Lilaa3
Copy link
Collaborator Author

Lilaa3 commented Sep 16, 2024

Non SM64 stuff looks okay. Please make sure to test export with some advanced cases like materials with two CI textures before merging.

Actual non-sm64 logic is unaffected besides one thing i changed now because i didnt notice the dynamic commands were broken aha (ive just been making sure displaylists were correct but today i made sure to test everything since I didn´t hear back from the person having the issues in the first place, yes i should've been more careful but I was expecting to hear back.. sorry)

@Lilaa3
Copy link
Collaborator Author

Lilaa3 commented Sep 16, 2024

Is there anyone else interested in testing this real quick? @Reonu ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request f3d Has to do with the "f3d" code common to all games review code please Ask that some other Fast64 dev reviews the code sm64 Has to do with the Super Mario 64 side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporting Hud results in Error
2 participants